jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Refactor: Improve country code conversion failure modes

Open hoffie opened this issue 3 years ago • 2 comments

I'd rather "convert to wireformat" and "convert from wireformat" were both "safe" - i.e. returned "Error" (e.g. -1) or a valid response, given any integer value, then have the caller deal with the error as it sees fit. Having to "know" about the IsCountryCodeSupported on top of the conversion methods seems excessively complicated.

Originally posted by @pljones in https://github.com/jamulussoftware/jamulus/pull/2829#discussion_r965319280

hoffie avatar Sep 09 '22 18:09 hoffie

@hoffie is this likely to get a PR?

pljones avatar Apr 19 '23 16:04 pljones

Dropping from 3.10.0.

pljones avatar Jun 25 '23 09:06 pljones