jamulus
jamulus copied to clipboard
Refactor: Improve country code conversion failure modes
I'd rather "convert to wireformat" and "convert from wireformat" were both "safe" - i.e. returned "Error" (e.g. -1) or a valid response, given any integer value, then have the caller deal with the error as it sees fit. Having to "know" about the
IsCountryCodeSupportedon top of the conversion methods seems excessively complicated.
Originally posted by @pljones in https://github.com/jamulussoftware/jamulus/pull/2829#discussion_r965319280
@hoffie is this likely to get a PR?
Dropping from 3.10.0.