jamulus Enable macOS Darkmode support for non legacy builds

Short description of changes The .plist files contained an opt out for macOS dark mode. Since we compile with Qt 5.15 or later on non legacy builds, there is no need to disable Dark mode support.

grafik

CHANGELOG: Mac: Enable dark-mode support on non legacy builds

Does this change need documentation? What needs to be documented and how?

No. Maybe screenshots.

Status of this Pull Request

Ready for review

What is missing until this pull request can be merged?

Nothing

Checklist

[x] I've verified that this Pull Request follows the general code principles
[x] I tested my code and it does what I want
[x] My code follows the style guide
[x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
[x] I've filled all the content above

Sep 02 '22 18:09 ann0see

@pljones @hoffie I know you don't have a Mac, so also asking @emlynmac for a review here.

Sep 12 '22 21:09 ann0see

What effect does it have on the mixer in Fancy skin?

Sep 12 '22 21:09 pljones

@pljones @hoffie I know you don't have a Mac, so also asking @emlynmac for a review here.

Is there a build I can fire up for a quick test?

Sep 12 '22 21:09 emlynmac

Will this change Jamulus' appearance based on system settings?

Yes.

What effect does it have on the mixer in Fancy skin?

See the screenshot.

Is there a build I can fire up for a quick test?

Just try the non legacy Mac artifact

Sep 13 '22 07:09 ann0see

See the screenshot.

Oh, that is Fancy skin in dark mode? Right! What does non-Fancy look like, then? (Similar to the settings page, I presume.)

Sep 13 '22 15:09 pljones

It seems as if the server name is not inverted. grafik

Sep 13 '22 15:09 ann0see

Mmm, yep, could do with a little more work. I think it's styled directly in the code.

It's also worth checking when connected to a server that's recording and when Mute Myself is enabled (and both).

Sep 13 '22 16:09 pljones

Pasting https://forum.qt.io/topic/103465/how-to-react-to-light-dark-mode-changes-in-macos/4 here. Debian 12 Qt6 seems to use the same values.

The stylesheet seems to be in clientdlg.cpp

Also: Qt6-wayland might need to be installed: https://unix.stackexchange.com/questions/598099/could-not-find-the-qt-platform-plugin-wayland

The return value of the palette().color call should be equal to QColor::fromRgbF(0.196078, 0.196078, 0.196078, 1);

Feb 12 '23 12:02 ann0see

Ok. @pljones Implemented for Linux Gnome. I'll test it on macOS later.

Feb 13 '23 11:02 ann0see

@pljones please merge this if you feel it's OK. last time I was able to test it on macOS everything was as in the screenshots above (especially the now merged PR which fixed the dark mode)

Apr 19 '23 20:04 ann0see

Are you saying the server name still displays in black on dark grey? If so, then it needs fixing still, yes?

Apr 20 '23 16:04 pljones

No. The now merged other PR fixed this issue.

Apr 20 '23 20:04 ann0see