jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

UI: Reverb slider off-center in MacOS as of 3.9.0 / Qt6

Open hoffie opened this issue 1 year ago • 13 comments

Discussed in https://github.com/orgs/jamulussoftware/discussions/2768

Originally posted by rdica August 1, 2022 This was first reported to me from an associate using Jamulus 3.9.0 MacOS Monterey. I upgraded my client on MacOS Catalina and see the same thing, the reverb slider is off-center.

No issues on Ubuntu 18.04 with QT 5.9.5.

Jamulus 3.9.0, QT 6.3.1, main MacOS build. (I installed the legacy dmg, it runs on MacOS Catalina and it does not display the reverb slider off-center. Its QT version is 5.9.9.)

Catalina: Screen Shot 2022-08-01 at 3 34 57 PM

Monterey: Screenshot_2022-08-01_15-38-16 .

hoffie avatar Aug 07 '22 20:08 hoffie

@rdica Thanks for the report. This sounds like this unresolved Qt bug: https://bugreports.qt.io/browse/QTBUG-98903 :(

I guess it might be possible to find workarounds by adjusting specific style options or painting manually, but I'm not sure if we want to do the latter. It would also be good to have someone on Mac OS develop/test this fix as this would certainly benefit from a tight feedback loop...

I'm adding a 3.9.1 target for now, but it might well be possible that we'll have to postpone it until a fixed Qt version is available.

hoffie avatar Aug 07 '22 20:08 hoffie

I tried each skin and the reverb slider was off-enter in each.

@rdica Could you please also check the other faders in the settings dialog, are they affected as well (network buffers, input balance; screenshots would help)?

hoffie avatar Aug 12 '22 22:08 hoffie

@rdica Two other things to try (not really expecting an improvement though...):

  1. QSlider with empty stylesheet (Assets)
  2. QSlider with dummy stylesheet (Assets)

hoffie avatar Aug 12 '22 23:08 hoffie

@hoffie Apologies for the delayed response....I tried both builds, using all skins, same results; still off-center.

rdica avatar Aug 16 '22 22:08 rdica

Screenshots of Settings dialog faders each of 3.9.0, and the two dev builds:

3.9.0 3 9 0

3.9.0dev-d95ebaa 3 9 0-d95xxxx-build

3.9.0dev-e08c36b 3 9 0-e08xxxx-build

rdica avatar Aug 16 '22 23:08 rdica

Thanks for the feedback! So somehow the technically similar faders in the settings dialog are not affected. I'll try to dive into potential differences.

hoffie avatar Aug 19 '22 08:08 hoffie

Sorry, did I miss something, the sliders in the above screenshots look off-center, same as the reverb slider...

rdica avatar Aug 19 '22 14:08 rdica

Hmm, sorry, I seem to have missed some details. I do see a slight mis-rendering of the knob (the ticks on the left are less overlapped by the knob compared to the right), is this what you mean? Or do you mean the layout of the whole slider, which seems to be slightly off compared to the header text?

hoffie avatar Aug 19 '22 14:08 hoffie

The former, same as it appears for the reverb slider, sorry.

rdica avatar Aug 19 '22 15:08 rdica

image OK, so 5.15.2 has the issue on Windows 10.

pljones avatar Aug 22 '22 16:08 pljones

Do we have anyone able to look into the cause on this? I'd like to know where the bug was introduced. @hoffie, as it's likely to be some change to the build dependencies, is this something you could pick up?

pljones avatar Sep 04 '22 10:09 pljones

It's worth a look at the screenshots from the issue mentioned above. It could be more evidence the issue isn't the Qt version itself but somewhere else in the build process.

pljones avatar Sep 07 '22 12:09 pljones

Moving to 3.10.0. If there's no progress there, it'll get closed.

pljones avatar Sep 17 '22 11:09 pljones

If someone has a fix for this, please raise the PR and reference this bug.

pljones avatar Apr 19 '23 16:04 pljones