jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Add `.gitattributes`

Open hoffie opened this issue 3 years ago • 9 comments

As suggested by @pgScorpio in #2585

TODO: Work out the details

hoffie avatar May 19 '22 20:05 hoffie

Is this for 3.9.0 or shall we postpone?

gilgongo avatar Jun 03 '22 10:06 gilgongo

Not strictly release-related. If it is ready, it can get in, if it isn't, it'll be done afterwards.

hoffie avatar Jun 03 '22 10:06 hoffie

Da-tagged

ann0see avatar Jun 14 '22 20:06 ann0see

Do we have any idea what's needed for this? If not, should we close for now?

pljones avatar Aug 29 '22 16:08 pljones

As mentioned in the other topic: See here or here.

pgScorpio avatar Aug 29 '22 17:08 pgScorpio

Could you please write a useful post? Those articles exist. So this ticket isn't needed? Or it is needed because some change is required somewhere. Say something that indicates where work is required in context.

pljones avatar Aug 29 '22 17:08 pljones

OK, (I thought it should already be clear from the mentioned related topics.)

As, by default, line endings are converted to the OS standard clang-format will sometimes have different results on Windows OS causing clang-format checks to fail on long line breakings for files edited and clang-formatted on Windows. This default behaviour can be changed by the .gitconfig file, but a .gitconfig file can't be included in the repo, so everybody would have to modify or create his own .gitconfig. But, since fixed line-endings can also be achieved with a .gitattributes file and a .gitattributes file can be included in the repo, my suggestion was to add this to the repo. What needs to be added to the .gitattributes file to force unix line-endings can be found in the links I provided....

pgScorpio avatar Aug 29 '22 18:08 pgScorpio

The point of having an issue in the project is to capture what applies to the project itself. Having general articles doesn't provide that. The issue should reference specific areas of change required, ideally referencing specific examples within the project. Generalisations do not provide a sound basis for someone deciding what needs changing.

pljones avatar Aug 29 '22 18:08 pljones

Not clearly defined, no bug identified, moving out to 3.10.0.

pljones avatar Sep 04 '22 10:09 pljones

Closing as no progress in two years. If the issue arises afresh, it can be looked at.

pljones avatar May 06 '24 09:05 pljones