jamulus
jamulus copied to clipboard
jamulussoftware
CI: Run Python syntax check
What is the current behaviour and why should it be changed?
We've got some Python scripts, but we don't have static code checkers active.
Describe possible approaches
We should have checks for
- coding style
- errors which can be detected statically
pyflakes?
Has this feature been discussed and generally agreed?
Roughly via Chat.
What do the python scripts do? I mean are the part of workflows or what? How do they impact the project?
$ find -not -path './libs/*' -name '*.py';
./.github/actions_scripts/analyse_git_reference.py
./tools/get_release_contributors.py
./tools/generate_json_rpc_docs.py
-> They affect the autobuild/releases, the release process and JSON-RPC doc updates.
👍 OK, so whilst we don't have many, they're embedded in what we do. So yes, we do need to do this. Better to take any hit now from the style check we choose whilst there's not too much to fix...
De-Tagged from 3.9.0. I think we should focus on getting the most important stuff in.
