jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Investigate opus build optimizations for ARM non-FP (Raspberry, Android, iOS)

Open hoffie opened this issue 2 years ago • 6 comments

What is the current behaviour and why should it be changed?

There are hints that it might make sense to set specific opus build flags to improve performance on low-spec arm builds (Raspberry, Android, iPhone):

  • openwebrtc issue
  • https://github.com/jamulussoftware/jamulus/blob/master/distributions/raspijamulus.sh#L53

Describe possible approaches

  • [ ] Find out if it's worth it (run benchmarks, do research, e.g. https://raspberrypi.stackexchange.com/questions/545/does-the-raspberry-pi-have-hardware-floating-point-support/546#546)
  • [x] Find out how to make qmake enable those flags (maybe some defines?): -D FIXED_POINT
  • [ ] Implement
  • [ ] Consider dropping manual opus installation in raspijamulus.sh?

Has this feature been discussed and generally agreed?

No.

hoffie avatar Mar 09 '22 09:03 hoffie

Looks like a -D FIXED_POINT might suffice based on opus' configure.ac. We could add that define in Jamulus.pro when building for armhf.

@ann0see We should probably investigate whether this might make sense for Android/iPhone as well. Might want an extra issue.

hoffie avatar Mar 19 '22 16:03 hoffie

@hoffie do you think this should go into 3.9.0 or rather in the next release?

ann0see avatar Apr 23 '22 20:04 ann0see

Moved to 3.9.1

pljones avatar Jun 18 '22 10:06 pljones

Moving to 3.10.0 as it's notabug.

pljones avatar Aug 29 '22 16:08 pljones

Nothing happening on the Android front. Moving to Triage and dropping the milestone.

pljones avatar Apr 19 '23 15:04 pljones

Moving to 3.11.0 as I'm looking to get some movement on Android.

pljones avatar Aug 12 '23 10:08 pljones