jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Releases: Rename .debs (drop _ubuntu_, dash for headless)

Open hoffie opened this issue 3 years ago • 12 comments

Has this feature been discussed and generally agreed?

Initial discussion here: https://github.com/jamulussoftware/jamulus/pull/2423#issuecomment-1048915034

Describe the solution you'd like

  • [x] Check that there is no technical reason to name the package like that
  • [ ] ~Rename jamulus_3.8.2_ubuntu_amd64.deb to jamulus_3.8.2_amd64.deb~
  • [ ] ~Rename headless version accordingly~
  • [ ] Replace _ by - for headless to match the package name.
  • [ ] grep the source for required updates (autobuild scripts use ubuntu)

Reasoning: We provide the .deb to support Debian and Ubuntu. .deb already hints that it targets these distributions. Adding ubuntu is confusing.

Describe alternatives that have been considered

Keep as-is

hoffie avatar Feb 23 '22 19:02 hoffie

Related to https://github.com/jamulussoftware/jamulus/issues/795

ann0see avatar Feb 24 '22 09:02 ann0see

Actually I don’t remember why we named it "Ubuntu" probably because most users are assumed to use Ubuntu and we build on Ubuntu. I think we could rename it. This might imply changes in unofficial scripts.

ann0see avatar Feb 25 '22 21:02 ann0see

@sthenos I think you wrote a script for WorldJam. You might need to change the install links one day

ann0see avatar Feb 25 '22 21:02 ann0see

@sthenos I think you wrote a script for WorldJam. You might need to change the install links one day

Simon originated the script, but I was the most recent contributor to it. Removing "ubuntu" from the name wouldn't matter. The code in question is this:

url=$( curl -s https://api.github.com/repos/jamulussoftware/jamulus/releases/latest | fgrep browser_download_url | grep -o '[^"]*headless[^"]*' )
file=${url##*/}

wget -nv -N $url || { echo failed to download package ; exit 1; }

sudo apt update || { echo failed to update apt database ; exit 1; }
sudo apt install -y ./$file || { echo failed to install package ; exit 1; }

and the first two lines do this:

tony@pi:/tmp $ url=$( curl -s https://api.github.com/repos/jamulussoftware/jamulus/releases/latest | fgrep browser_download_url | grep -o '[^"]*headless[^"]*' )
tony@pi:/tmp $ file=${url##*/}
tony@pi:/tmp $ echo $url
https://github.com/jamulussoftware/jamulus/releases/download/r3_8_2/jamulus_headless_3.8.2-1_ubuntu_amd64.deb
tony@pi:/tmp $ echo $file
jamulus_headless_3.8.2-1_ubuntu_amd64.deb

softins avatar Feb 28 '22 17:02 softins

Ah. Ok. So basically it’s semi-officially supported. It might make sense to put it into the installscripts repo.

ann0see avatar Feb 28 '22 17:02 ann0see

Current status:

I am not feeling a strong need of removing or not removing "ubuntu" from the file name. Hoffie is slightly pro, softins is slightly con, so I assume the decision is a draw.

Suggestions involved

  • Renaming all files by appending the OS as a folder
  • Renaming ubuntu to linux or debian
  • Doing nothing

I think renaming to debian would be good although we can’t for sure guarantee Debian compatibility

ann0see avatar Mar 07 '22 06:03 ann0see

Yep. I've crossed out the no langer planned TODO items. jamulus_headless -> jamulus-headless would still help with consistency with the actual package name, so I've left this TODO item open.

hoffie avatar Mar 07 '22 08:03 hoffie

So the only thing left is the rename?

ann0see avatar Apr 22 '22 19:04 ann0see

a) If the "ubuntu" is staying, can the issue title be changed, please? b) @softins, if this went ahead, would you be able to update Simon's Script after the release? c) Who maintains the "ubuntu" build script?

pljones avatar May 22 '22 17:05 pljones

b) @softins, if this went ahead, would you be able to update Simon's Script after the release?

Yes, I could do that, but would need a ping or mention to alert me, as I still don't have time to follow what's going on with Jamulus.

softins avatar May 22 '22 17:05 softins

Do we want to use the jamulus-headless name now? This needs changes on the website

ann0see avatar Jun 14 '22 21:06 ann0see

As there's no pressing reason for this being included, I've moved it to 3.9.1.

pljones avatar Jun 18 '22 11:06 pljones

Is anything else going to get progressed on this?

pljones avatar Aug 29 '22 16:08 pljones

I'll shortly open two PRs (app and docs)

ann0see avatar Aug 29 '22 16:08 ann0see