jamulus
jamulus copied to clipboard
Releases: Rename .debs (drop _ubuntu_, dash for headless)
Has this feature been discussed and generally agreed?
Initial discussion here: https://github.com/jamulussoftware/jamulus/pull/2423#issuecomment-1048915034
Describe the solution you'd like
- [x] Check that there is no technical reason to name the package like that
- [ ] ~Rename jamulus_3.8.2_ubuntu_amd64.deb to jamulus_3.8.2_amd64.deb~
- [ ] ~Rename headless version accordingly~
- [ ] Replace _ by - for headless to match the package name.
- [ ] grep the source for required updates (autobuild scripts use
ubuntu
)
Reasoning: We provide the .deb to support Debian and Ubuntu. .deb
already hints that it targets these distributions. Adding ubuntu
is confusing.
Describe alternatives that have been considered
Keep as-is
Related to https://github.com/jamulussoftware/jamulus/issues/795
Actually I don’t remember why we named it "Ubuntu" probably because most users are assumed to use Ubuntu and we build on Ubuntu. I think we could rename it. This might imply changes in unofficial scripts.
@sthenos I think you wrote a script for WorldJam. You might need to change the install links one day
@sthenos I think you wrote a script for WorldJam. You might need to change the install links one day
Simon originated the script, but I was the most recent contributor to it. Removing "ubuntu" from the name wouldn't matter. The code in question is this:
url=$( curl -s https://api.github.com/repos/jamulussoftware/jamulus/releases/latest | fgrep browser_download_url | grep -o '[^"]*headless[^"]*' )
file=${url##*/}
wget -nv -N $url || { echo failed to download package ; exit 1; }
sudo apt update || { echo failed to update apt database ; exit 1; }
sudo apt install -y ./$file || { echo failed to install package ; exit 1; }
and the first two lines do this:
tony@pi:/tmp $ url=$( curl -s https://api.github.com/repos/jamulussoftware/jamulus/releases/latest | fgrep browser_download_url | grep -o '[^"]*headless[^"]*' )
tony@pi:/tmp $ file=${url##*/}
tony@pi:/tmp $ echo $url
https://github.com/jamulussoftware/jamulus/releases/download/r3_8_2/jamulus_headless_3.8.2-1_ubuntu_amd64.deb
tony@pi:/tmp $ echo $file
jamulus_headless_3.8.2-1_ubuntu_amd64.deb
Ah. Ok. So basically it’s semi-officially supported. It might make sense to put it into the installscripts repo.
Current status:
I am not feeling a strong need of removing or not removing "ubuntu" from the file name. Hoffie is slightly pro, softins is slightly con, so I assume the decision is a draw.
Suggestions involved
- Renaming all files by appending the OS as a folder
- Renaming ubuntu to linux or debian
- Doing nothing
I think renaming to debian would be good although we can’t for sure guarantee Debian compatibility
Yep. I've crossed out the no langer planned TODO items. jamulus_headless -> jamulus-headless would still help with consistency with the actual package name, so I've left this TODO item open.
So the only thing left is the rename?
a) If the "ubuntu" is staying, can the issue title be changed, please? b) @softins, if this went ahead, would you be able to update Simon's Script after the release? c) Who maintains the "ubuntu" build script?
b) @softins, if this went ahead, would you be able to update Simon's Script after the release?
Yes, I could do that, but would need a ping or mention to alert me, as I still don't have time to follow what's going on with Jamulus.
Do we want to use the jamulus-headless name now? This needs changes on the website
As there's no pressing reason for this being included, I've moved it to 3.9.1.
Is anything else going to get progressed on this?
I'll shortly open two PRs (app and docs)