jamulus icon indicating copy to clipboard operation
jamulus copied to clipboard

Published 20 hours ago • verified publisher icon jamulussoftware

windows/sound.cpp: Rename CheckDeviceCapabilities()

Open hoffie opened this issue 3 years ago • 4 comments

Describe the bug CheckDeviceCapabilities() in windows/sound.cpp does more than what the name suggests: It has side effects such as updating instance variables such as lNumInChan.

Expected behavior

Have a name which makes it clear that updates happen.

Version of Jamulus d5d4691221b76bc648d605dac867aeaa561d0a52

cc @ann0see @pljones

hoffie avatar Mar 31 '21 18:03 hoffie

Maybe a stupid question, but what does "good first issue" mean? Does it mean, it's a good issue for a new developer?

DominikSchaller avatar Mar 31 '21 21:03 DominikSchaller

what does "good first issue" mean? Does it mean, it's a good issue for a new developer?

Yes, this was the intention. I think this issue requires little Jamulus-specific context but could be worked on by some developer who is new to the project.

hoffie avatar Mar 31 '21 22:03 hoffie

Any news here? @DominikSchaller @henkdegroot or @pgScorpio (sorry for the pings...) do you want to rename the function?

ann0see avatar Apr 22 '22 19:04 ann0see

@ann0see

Any news here? @DominikSchaller @henkdegroot or @pgScorpio (sorry for the pings...) do you want to rename the function?

No, just wait for the sound redesign.... It's already changed there.

pgScorpio avatar Apr 22 '22 23:04 pgScorpio