kp2bw icon indicating copy to clipboard operation
kp2bw copied to clipboard

XPath literal strings are not escaped, thus an exception is raised when then contain a `"` (quote)

Open shadow1runner opened this issue 4 years ago • 7 comments

Hi,

in case there is a custom field containing a double quote (e.g. "secret" example text) your (awesome ;-)) importer fails due to a malformed xpath expression (yielding lxml.etree.XPathEvalError: Invalid predicate)

The issue is upstream in pykeepass - will raise an issue there and I guess it's best to keep this one open here in case sb. else is facing a similar issue

shadow1runner avatar Mar 23 '21 18:03 shadow1runner

Thanks for opening the issue in the pykeepass project. I'll update kp2bw as soon as a fix for this has been pushed to upstream.

jampe avatar Mar 23 '21 23:03 jampe

Also a colon (:) in the password field seems to break the import

wischi-chr avatar Jun 16 '21 06:06 wischi-chr

Still facing the issue...

TensorBlast avatar Jun 23 '22 02:06 TensorBlast

The issue is still open upstream as you can see above. If you want to contribute, please submit your PR to the upstream repo to solve this issue for good. Thanks!

jampe avatar Jul 03 '22 13:07 jampe

I know what can be done and what cannot. I simply provided an update. Get off your high horse telling people to contribute or stay silent.

On Sun, Jul 3, 2022, 19:23 jampe @.***> wrote:

The issue is still open upstream as you can see above. If you want do contribute, please submit your PR to the upstream repo to solve this issue for good. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/jampe/kp2bw/issues/10#issuecomment-1173094689, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKJU2TBTV77ZS5KPL42NDTVSGLPFANCNFSM4ZVW5GIA . You are receiving this because you commented.Message ID: @.***>

TensorBlast avatar Jul 03 '22 14:07 TensorBlast

Get off your high horse telling people to contribute or stay silent

Log off, go outside and come back once you get your act back together. People invest their free time and provide tools for free and you have nothing better to do than to complain.

Your update was also next to worthless, because everybody can see the state of this ticket (and the upstream ticket) hasn't changed. So I'm sorry to say it that way but the only solution is to shut up or fix it yourself. Alternatively you could also offer some money if you are unable to fix it yourself.

I'm happy to fix it for €1000,- maybe someone else is willing to make it for less ;-)

wischi-chr avatar Jul 03 '22 14:07 wischi-chr

Get off your high horse telling people to contribute or stay silent

Log off, go outside and come back once you get your act back together. People invest their free time and provide tools for free and you have nothing better to do than to complain.

Your update was also next to worthless, because everybody can see the state of this ticket (and the upstream ticket) hasn't changed. So I'm sorry to say it that way but the only solution is to shut up or fix it yourself. Alternatively you could also offer some money if you are unable to fix it yourself.

I'm happy to fix it for €1000,- maybe someone else is willing to make it for less ;-)

Im happy to have you ended for that much so...

TensorBlast avatar Jul 18 '22 03:07 TensorBlast