docker-palworld-dedicated-server icon indicating copy to clipboard operation
docker-palworld-dedicated-server copied to clipboard

[Feature Request] Update Docker Hub Readme on CI-push

Open jammsen opened this issue 1 year ago • 3 comments

Have you read the Important information text above

  • [X] Yes i did

Current behavior

I have to copy paste manually every change i do in the readme.md here to publish it to docker-hub

Desired behavior

A Github Actions CI-solution updates the readme on docker-hub from here.

Links to screenshots

No response

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Software setup

  • OS:
  • Docker:

Hardware setup

  • vCPU:
  • RAM:
  • Disk:

Additional context

No response

jammsen avatar Jan 23 '24 00:01 jammsen

Hey thanks for the image, I actually do something similar with another project I wrote. You can use a github action for this

- name: Update Dockerhub Documentation
    uses: peter-evans/dockerhub-description@v3
    if: ${{ (fromJSON(inputs.latest) == true) && (github.event_name != 'pull_request') }}
    with:
      username: ${{ inputs.dockerhub_username }}
      password: ${{ inputs.dockerhub_token }}
      repository: ${{ github.repository }}

I can also open a PR when I get some time but username/password come from my inputs which are environment secrets in the repo settings. Hope this helps!

pchang388 avatar Jan 23 '24 04:01 pchang388

Hello @pchang388 i think thats enough for a rough idea and research this further, thank you very much.

jammsen avatar Jan 23 '24 08:01 jammsen

I solved this by this commit: https://github.com/jammsen/docker-palworld-dedicated-server/commit/66866fc21d31c470c7087632d3c8f4fe4b22ffa9

But now i get an error from the plugin and the API image

Manually copy-pasting the 35 Kilobyte works just fine 🤷

jammsen avatar Jan 25 '24 21:01 jammsen

Now the read is reduced but im still getting and error: https://github.com/peter-evans/dockerhub-description/issues/248

jammsen avatar Jan 30 '24 18:01 jammsen

Does this help? https://docs.docker.com/build/ci/github-actions/update-dockerhub-desc/

mattholy avatar Feb 05 '24 08:02 mattholy

Does this help? https://docs.docker.com/build/ci/github-actions/update-dockerhub-desc/

Did already fix it, Peter helped out, but yeah that would have helped. I did assign his repo instead of mine, didnt understand the readme correctly. Its already fixed, still thanks for the help @mattholy

jammsen avatar Feb 05 '24 11:02 jammsen

Feature was implemented see: https://github.com/jammsen/docker-palworld-dedicated-server/blob/develop/.github/workflows/docker-build-and-push-prod.yml#L61

Closing this.

jammsen avatar Feb 05 '24 11:02 jammsen