docker-palworld-dedicated-server
docker-palworld-dedicated-server copied to clipboard
jammsen
GHCR docker container?
Have you read the Important information text above
- [X] Yes i did
Current behavior
Container is only shared on docker hub.
Desired behavior
GitHub Container Registry is also a place to get the containers from
Links to screenshots
No response
To Reproduce
N/A
Software setup
N/A
Hardware setup
N/A
Additional context
GHCR has a lot more permissive rate limiting.
Hello @aaomidi IF i understand you correctly, you want me to NOT host on Docker-Hub or to ALSO host on Github Container Registry? Could you please clarify what you need and want me to do? This issue is little sparse. Could you please clarify what you mean by "GHCR has a lot more permissive rate limiting."? Not sure i understand.
My motherlanguage is German, sorry if my english isnt good enough to undertand this slim-describen issue.
Could you please clarify what you mean by "GHCR has a lot more permissive rate limiting."? Not sure i understand.
Dockerhub has rate limiting in place: https://docs.docker.com/docker-hub/download-rate-limit/
I dont believe its something you, as the person creating the image should worry about. Host wherever you feel appropriate
Hey @jseiser - Oh he means the Docker Image Pull Limit, now i understand.
Hey @aaomidi - Well if you hit your limit by pulling 200 images with an user account, im not sure what i can do about that 😄 but if you ask me if i could add GHCR as a 2nd source repo, i would have to look into that.
Oh yeah I was asking for GHCR in addition to docker hub. I can even make the PR for this, it's pretty simple since you just add another tag to the image and push it to GHCR.
Hey @aaomidi that PR looked good to me so i merged it, the documentation didnt really mention to setup permissions before hand so i had to figure out that the hard way. Ive dont that and now its on GHCR also.
But its weird,it looks like its 2 architectures somehow?!
Would this be compatible with #23 also?
Hey @aaomidi that PR looked good to me so i merged it, the documentation didnt really mention to setup permissions before hand so i had to figure out that the hard way. Ive dont that and now its on GHCR also.
But its weird,it looks like its 2 architectures somehow?!
Would this be compatible with #23 also?
I made it now compatible with #23
@aaomidi But my question remains un-answered, why are there no 2 architectures with is one of them unknown??!?
Thank you so much for figuring out the few things there.
I believe what's happening is provenance attestations: https://docs.docker.com/build/attestations/slsa-provenance/
I remember running into this problem before. Seems like it is a known issue with GHCR: https://github.com/orgs/community/discussions/45969
I remember just working around it by switching to docker/build-push-action@v3
Thank you so much for figuring out the few things there.
No problem, happy to help
I believe what's happening is provenance attestations: https://docs.docker.com/build/attestations/slsa-provenance/
I remember running into this problem before. Seems like it is a known issue with GHCR: https://github.com/orgs/community/discussions/45969
I remember just working around it by switching to
docker/build-push-action@v3
ehh yeah .... 😕
Oh, some potentially good news: https://github.com/docker/build-push-action/issues/900
Can this issue be closed?
If you like this project, please give this repo and the docker-hub-repo a Star.