Jamil

Results 709 comments of Jamil

> > This seems like a bug introduced in #5558 possibly. > > I think this because we cache the logger in a `static`. There is a code comment about...

> Do you get ANSI escape codes when do you adb logcat I do, but my terminal interprets them. Android Studio doesn't unfortunately and they're printed with a bunch of...

> I can reproduce this on my phone but I can't reproduce it on my computer. There, setting `ansi=false` won't make the fields italic. How did you manage to run...

@thomaseizinger I can confirm these issues persist. The log format issue was introduced by adding a `fmt()` layer in https://github.com/firezone/firezone/commit/8973cc5785a31666d5657bbdae0f4e552ff54688 -- judging from the [crate docs](https://docs.rs/tracing-subscriber/latest/tracing_subscriber/fmt/format/struct.Format.html#) they don't seem to...

> Thanks for digging into this! There is the `with_ansi` function which we already call with `false` that is meant to trickle down to everything as far as I can...

Nevermind on my unloadLibrary idea: > Unloading a library in the JVM, specifically the opposite of System.loadLibrary, is not directly supported. Once a native library is loaded into the JVM,...

> > Is `NXDOMAIN` actually the correct response here? Shouldn't we just return an empty response? If we get this far in the code, we know the domain, so why...

> > > > > Is `NXDOMAIN` actually the correct response here? Shouldn't we just return an empty response? If we get this far in the code, we know the...

I wonder if this is the issue behind #5637. It would also break TXT too for headless clients doing Let's Encrypt validation for example. Maybe we should forward all other...