Jamie Brandon

Switch to a better code review tool

7

Wishlist: 1. Allow marking individual hunks as read (github only allows marking entire files as read). 2. Making a one line change to a file just shows that new hunk...

Some changes worth trying before vng is stabilized: * Don't use containers for primitives. * For fixed-length types just concatenate all the bytes. Reading can be zero-copy. * For integers,...

Neither the zng reader nor zed.NewValue does any validation, so reading a bad zng file can produce eg Float64s with 2 bytes, which blow up in later code.

For example: ``` package main import ( "bytes" "fmt" "github.com/brimdata/zed" "github.com/brimdata/zed/zbuf" "github.com/brimdata/zed/zio" "github.com/brimdata/zed/zio/zngio" //"github.com/brimdata/zed/zcode" //"github.com/brimdata/zed/zson" ) func main() { bytesReader := bytes.NewReader([]byte("\x14\x00\x1b\x01\x100")) context := zed.NewContext() reader := zngio.NewReader(context, bytesReader) var...

[This loop](https://github.com/brimdata/zed/blob/47cdb95d319d4679cb0a2d3bba86a5a62ce7c4bb//value.go#L445) never ends because [Untag returns typ, nil](https://github.com/brimdata/zed/blob/47cdb95d319d4679cb0a2d3bba86a5a62ce7c4bb//complex.go#L343). To repro: ``` > dlv debug cmd/zq/main.go -- 'yield cast(this, ) | yield this.x' ~/test.json (dlv) break github.com/brimdata/zed.(*Value).Under Breakpoint 1 set...

VNG bounds error in roundtrip

2

To reproduce: ``` > git checkout origin/jamii-fuzz-vng-repro > cd vng > ZED_USE_DICT=1 go test -fuzz FuzzVngRoundtripGen/f5c94e3a7a95e75c --- FAIL: FuzzVngRoundtripGen (0.00s) --- FAIL: FuzzVngRoundtripGen/f5c94e3a7a95e75c (0.00s) panic: runtime error: slice bounds out...

VNG dict vectors don't always roundtrip succesfully

1

To reproduce: ``` > git checkout origin/jamii-fuzz-vng-repro > cd vng > ZED_USE_DICT=1 go test -run FuzzVngRoundtripGen/0169eec3758e54cb --- FAIL: FuzzVngRoundtripGen (0.00s) --- FAIL: FuzzVngRoundtripGen/0169eec3758e54cb (0.00s) vng_test.go:123: comparing: len(in)=2 vs len(out)=2 vng_test.go:132:...

``` > zq -f vng -o wrccdc_test.vng 'yield this' wrccdc.zng > zq -f zson 'count()' wrccdc_test.vng panic: bad uvarint: -11 goroutine 14 [running]: github.com/brimdata/zed/zcode.(*Iter).Next(0x2545f40?) /home/jamie/zed/zcode/iter.go:26 +0x219 github.com/brimdata/zed/vng/vector.(*PrimitiveReader).ReadBytes(0x0?) /home/jamie/zed/vng/vector/primitive.go:210 +0x4c github.com/brimdata/zed/vng/vector.(*PrimitiveReader).Read(0x1?,...

Negative results for trivial benchmarks

3

`(with-progress-reporting (bench (let [x nil] (if x true false))))` Warming up for JIT optimisations 10000000000 ... compilation occured before 2382422 iterations classes loaded before 69087606 iterations Estimating execution count ......