episodes icon indicating copy to clipboard operation
episodes copied to clipboard

Show notes editor activity

Open daniele-athome opened this issue 9 years ago • 2 comments

Here is the "full screen dialog" (which is actually an activity) to edit show notes. Tell me if you like it - I can make adjustments of course. The only thing I had problem with was the floating action button. In order to make it stick to the bottom even before scrolling down, I think it should be inside the activity's layout. It's taking me longer to explain, you can try it and you'll understand what I mean :-)

I tried to stick with your code style and methods as much as possible, feel free to fix code style as you see fit.

Signed-off-by: Daniele Ricci [email protected]

daniele-athome avatar Oct 04 '15 10:10 daniele-athome

Now that I've been using it... I don't know... I still don't like it 100%... I think other apps like Google Calendar uses something else than a different activity to make that popup window. I'll investigate further, in the meanwhile you can try it yourself and tell me what you think.

daniele-athome avatar Oct 07 '15 09:10 daniele-athome

I like it. :)

Could we have an "X" button instead of the back arrow on the edit activity, to make it clear that it discards the note instead of saving it? And could the activity's title be "Edit notes"?

It's a shame about the FAB not just knowing we want it anchored to the bottom of the screen rather than the fragment. I think you're right - it needs to be in the activity. I came across this answer on stack overflow - http://stackoverflow.com/questions/31596640/fab-animation-with-viewpager-tabslider/31663686#31663686. Would you mind trying to do something like that?

If you find a better way than the activity then that's great but if not I'd be happy to merge it.

jamienicol avatar Oct 09 '15 09:10 jamienicol