Jamie Hewitt
Jamie Hewitt
> @jamiehewitt15 I have seen that these tests are also failing in the `main` branch. Any ideas about what can be failing? @mihaisc @bogdanfazakas The test that is failing is...
> By now tending towards @idiom-bytes's suggestion of simply writing stuff in the markdown files and be done with it. If that's the direction we go in then we could...
We have an internal document on testing (created prior to the V4 release) which this can be based on.
It seems that something odd maybe happening on the gitbook side which is messing up the tables. @MantisClone reported having trouble with this
> I have created a change request directly on gitbook. I submitted for review on Gitbook and left some comments there as well. CC @AnaLoznianu @jamiehewitt15 The workflow we follow...
@alexcos20 Do we still need this?
Seems good, just the tests that need fixing I think
I changed it back to string as it was causing problems: https://github.com/oceanprotocol/ocean-subgraph/pull/477 Will do another PR for this with more testing.
> so when assigning a value to lastPriceToken we need to do a getToken From what I can see we already call `getToken()` before updating the `lastPriceToken` in `handleOrderStarted`. https://github.com/oceanprotocol/ocean-subgraph/blob/5da91c228211544fc76f26e3cb7df1884a274b21/src/mappings/erc20Templates.ts#L39...
> On Order , `lastPriceToken` should be `Token` Why only on Order? `lastPriceToken` in Token is string, I'm not sure why they would be different?