geomeppy icon indicating copy to clipboard operation
geomeppy copied to clipboard

Release candidate

Open jamiebull1 opened this issue 2 years ago • 3 comments

jamiebull1 avatar Nov 16 '22 17:11 jamiebull1

@jamiebull1, I don't think the patches in geomeppy on the IDF class make use of eppy's v0.5.60 fix of extensible objects. See https://github.com/santoshphilip/eppy/issues/391

samuelduchesne avatar Nov 18 '22 14:11 samuelduchesne

@jamiebull1, I don't think the patches in geomeppy on the IDF class make use of eppy's v0.5.60 fix of extensible objects. See santoshphilip/eppy#391

I made a quick and dirty attempt at patching this #252

samuelduchesne avatar Nov 18 '22 14:11 samuelduchesne

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@265d0b5). Click here to learn what that means. The diff coverage is 88.01%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #249   +/-   ##
=========================================
  Coverage          ?   89.47%           
=========================================
  Files             ?       16           
  Lines             ?     1434           
  Branches          ?        0           
=========================================
  Hits              ?     1283           
  Misses            ?      151           
  Partials          ?        0           
Impacted Files Coverage Δ
geomeppy/view_geometry.py 63.10% <60.97%> (ø)
geomeppy/geom/vectors.py 95.40% <80.00%> (ø)
geomeppy/idf.py 88.46% <83.33%> (ø)
geomeppy/io/obj.py 81.05% <83.33%> (ø)
geomeppy/recipes.py 93.02% <86.56%> (ø)
geomeppy/geom/polygons.py 84.09% <92.98%> (ø)
geomeppy/patches.py 94.73% <94.44%> (ø)
geomeppy/geom/surfaces.py 97.02% <94.64%> (ø)
geomeppy/builder.py 100.00% <100.00%> (ø)
geomeppy/extractor.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 265d0b5...4f5f790. Read the comment docs.

codecov[bot] avatar Nov 24 '22 19:11 codecov[bot]