react-loadable icon indicating copy to clipboard operation
react-loadable copied to clipboard

Published 20 hours ago • verified publisher icon jamiebuilds

componentWillMount removed

Open mattlockyer opened this issue 5 years ago • 8 comments

removed componentWillMount and moved this._loadModule(); into componentDidMount.

squashes the warning as componentWillMount was marked as UNSAFE_componentWillMount().

mattlockyer avatar Mar 29 '20 23:03 mattlockyer

https://github.com/jamiebuilds/react-loadable/pull/220

alex-zhang avatar Mar 30 '20 04:03 alex-zhang

@alex-zhang alternative?

mattlockyer avatar Mar 30 '20 04:03 mattlockyer

@alex-zhang alternative?

https://github.com/jamiebuilds/react-loadable/pull/220#issuecomment-582173175

alex-zhang avatar Mar 30 '20 04:03 alex-zhang

Any plans to merge this?

bogas04 avatar Nov 06 '20 06:11 bogas04

Any plan to merge this?

hitmands avatar Nov 08 '20 17:11 hitmands

Can this be merged please?

dagoltz avatar Jan 18 '21 13:01 dagoltz

componentDidMount will not trigger during SSR.

For anyone interested, here's my solution to get rid of the warning (React 16 + 17) and still get this working (client+SSR).

https://github.com/jamiebuilds/react-loadable/pull/213#issuecomment-778246548

slorber avatar Feb 12 '21 15:02 slorber

Can this be merged please?

johnathanmelo avatar Sep 15 '21 20:09 johnathanmelo