react-loadable icon indicating copy to clipboard operation
react-loadable copied to clipboard

Published 20 hours ago • verified publisher icon jamiebuilds

Updated componentWillMount to componentDidMount

Open Daggron opened this issue 5 years ago • 15 comments

I was using this in my project and i saw its using componentWillMount which will be deprected in the new version of react so i updated it with componentDidMount. To avoid deprecation and remove the warning

Daggron avatar Dec 17 '19 12:12 Daggron

Also interested in this change 🎉

stonecrafter avatar Jan 16 '20 15:01 stonecrafter

Any plan on merging this PR? and release date?

brendonco avatar Jan 22 '20 10:01 brendonco

Can someone help merge this PR and publish the lib :)

alirizvi2008 avatar Jan 27 '20 14:01 alirizvi2008

Seems like a very small change for this codebase, would love to see it merged and published soon!

dabyland avatar Feb 04 '20 15:02 dabyland

Guys, I considered react-loadable has not been maintaining, please migrate to other package such as react-imported-component, loadable-component... Good luck.

viiiprock avatar Feb 04 '20 23:02 viiiprock

Anyone can merge this PR? I got same warning.

goldenshooter avatar Feb 08 '20 04:02 goldenshooter

same warning. any update?

alex-zhang avatar Feb 09 '20 16:02 alex-zhang

why this PR wont be merged?

mouhsnimohamed avatar Feb 11 '20 10:02 mouhsnimohamed

I don't mean to harp on this pull request but it's a one line change that has been open for 2 months with no update. Can we please have some communication for the cause of the hold up?

Thanks!

dabyland avatar Feb 17 '20 13:02 dabyland

Hi all, I put the fixed version with addition of build files in my github repo so you can change your npm package to this if you need a quick fix.

should look like this in package.json:

"react-loadable": "github:p0o/react-loadable",

p0o avatar Mar 20 '20 12:03 p0o

@p0o it works, thanks. I cloned this repo, and found "yarn start" not work at all.

cnscorpions avatar May 27 '20 08:05 cnscorpions

@cnscorpions I think I built it with npm.

p0o avatar May 27 '20 10:05 p0o

So it is clear that we will be migrating off react-loadable at some point. I certainly understand the challenges of donating your time to an open source project. However, those of us in larger projects can't necessarily do that immediately. We also can't cutover to a random github fork, as there is no guarantee that won't change or disappear.
So, in the meantime, we would really appreciate it if the maintainers of this repo could take the few minutes it would take to merge this PR and publish a new patch version to npm. 🙏 Thanks for your time and for building this very useful tool.

darcyadams avatar Jul 24 '20 17:07 darcyadams

So it is clear that we will be migrating off react-loadable at some point. I certainly understand the challenges of donating your time to an open source project. However, those of us in larger projects can't necessarily do that immediately. We also can't cutover to a random github fork, as there is no guarantee that won't change or disappear. So, in the meantime, we would really appreciate it if the maintainers of this repo could take the few minutes it would take to merge this PR and publish a new patch version to npm. 🙏 Thanks for your time and for building this very useful tool.

Suggestion: You can fork my repo up there into your github organization or publish your npm package if you need a more reliable solution.

p0o avatar Jul 26 '20 05:07 p0o

For anyone interested, here's my solution to get rid of the warning (React 16 + 17) and still get this working (client+SSR).

https://github.com/jamiebuilds/react-loadable/pull/213#issuecomment-778246548

slorber avatar Feb 12 '21 15:02 slorber