obsidian-todoist-plugin icon indicating copy to clipboard operation
obsidian-todoist-plugin copied to clipboard

Make "title" optional

Open ottsch opened this issue 3 years ago • 6 comments

Would be nice to be able optionally not show any title because I might already have a heading above.

ottsch avatar Jun 15 '21 07:06 ottsch

I had the same want. I have a fork that does this, but ended up changing some of the structural HTML to add some spacing between the task list and the heading above. Long way of saying, I started making more changes in my fork and would need to go back and extract just the title toggle to submit an atomic PR. Let me know if this is still relevant and I'll do so.

CleanShot 2023-08-10 at 16 04 27

g12r avatar Aug 10 '23 22:08 g12r

I think perhaps a better approach is to just remove the title option as a breaking change in a v2.0 release. Really, if you want a heading, the native Obsidian ones are just better for integrating into the rest of the application, theming, etc.

jamiebrynes7 avatar Aug 11 '23 17:08 jamiebrynes7

I worked a bit more on the TodoistQuery markup to accommodate eliminating the existing H4 title. If you just eliminate it, the existing refresh button still consumes space at the top, leading to a big gap between, say, the native Obsidian header above it and the first task. While I was floating the refreshTodos button, I went further and added an add todo button, and I made them all look similar to the native Obsidian edit-markdown-block button.

I also added an 'appended date' format that happens to be how I like to see dates (on the same line as the task), with a enable/disable setting and the ability to put whatever moment format you want to use for your date formats.

It's a bit of a heavy commit to do as an uncoordinated PR and I didn't know what you might be interested in terms of v2.0 changes, @jamiebrynes7.

Changelog entries here

GIF of updated buttons.

g12r avatar Aug 12 '23 22:08 g12r

I worked a bit more on the TodoistQuery markup to accommodate eliminating the existing H4 title. If you just eliminate it, the existing refresh button still consumes space at the top, leading to a big gap between, say, the native Obsidian header above it and the first task. While I was floating the refreshTodos button, I went further and added an add todo button, and I made them all look similar to the native Obsidian edit-markdown-block button.

I also added an 'appended date' format that happens to be how I like to see dates (on the same line as the task), with a enable/disable setting and the ability to put whatever moment format you want to use for your date formats.

It's a bit of a heavy commit to do as an uncoordinated PR and I didn't know what you might be interested in terms of v2.0 changes, @jamiebrynes7.

Changelog entries here

GIF of updated buttons.

This is awesome! I just figured out how to install your edits. Is there something I'm missing to have the project header and first task not have such large padding? It seems to be hit or miss when running your edition.

Thanks!

clcoble avatar Jan 04 '24 15:01 clcoble

Interesting... I think it's all governed by the CSS but I did depart from some of how the the TodoistQuery sets up the structure. The operative classes and markup are likely in this vicinity:

https://github.com/g12r/obsidian-todoist-plugin/blob/bb78c1cd7cb47f2105599899c0b5cbe8c020d7c2/src/ui/TodoistQuery.svelte#L99

If you have a screen shot or repro, I can take a look when back from a trip.

Unrelated, I've lost the task item checkboxes on my end and I need to go see what those stopped appearing in mid-Dec. No known code changes involved that I could see.

g12r avatar Jan 12 '24 00:01 g12r

Interesting... I think it's all governed by the CSS but I did depart from some of how the the TodoistQuery sets up the structure. The operative classes and markup are likely in this vicinity:

https://github.com/g12r/obsidian-todoist-plugin/blob/bb78c1cd7cb47f2105599899c0b5cbe8c020d7c2/src/ui/TodoistQuery.svelte#L99

If you have a screen shot or repro, I can take a look when back from a trip.

Unrelated, I've lost the task item checkboxes on my end and I need to go see what those stopped appearing in mid-Dec. No known code changes involved that I could see.

Much appreciated but it’s now working for me somehow. Appreciate your changes to make this an even better plugin!

clcoble avatar Jan 13 '24 03:01 clcoble