Jamey Sharp

Results 262 comments of Jamey Sharp

I suspect the silence here means that nobody on the core Wasmtime team wants to take responsibility for RPM builds. We try to make sure that if we merge something,...

Do you both feel this is ready for merge, then? I've glanced over it and it looks reasonable to me, but I'm not at all familiar with how thread-local storage...

Just glancing at older PRs: is this still a direction you're interested in, @avanhatt? Or have you all found a different direction that's meeting your needs?

Ooh, I am eager to look at this on Monday!

It's been suggested (by a couple different people, I think, but I've lost track of who) that when we have a wasm program we want to try running, we should...

It looks to me like `LabelValueLoc::SPOffset` is supposed to get used here, so maybe deleting it isn't the right plan, but it's apparently hard to use correctly: https://github.com/bytecodealliance/wasmtime/blob/ca36ce57c2e7903fe2410aae95d564bb7d792cb5/cranelift/codegen/src/machinst/vcode.rs#L1095-L1108 If this...

It looks like cranelift-fuzzgen doesn't generate either variant of `bitcast` yet, and the other fuzzers generate wasm rather than CLIF. So I'm not surprised that fuzzing hasn't exercised this part...

I haven't written any significant Ruby before, so I guess I'm not surprised that CI reports there are a bunch of code style issues. I'll have to figure out how...

Sure, I can understand that. The problem I'm trying to tackle is there's a catch-22: if publishers don't implement it, readers won't implement it, and vice versa. I heard from...

Thanks for the Rubocop fixes! I've refactored further to eliminate its complaint about the AbcSize metric, and now there are no Rubocop complaints. Hooray! Is this better?