jamesyu
vNext
Hi there,
as I am planning to use GMailr for a current project, I started to work on it quite a lot. It would be great if we could pull all the changes I made in, which include:
- I fixed most of the broken pieces, including the numChange observer, the canvas, etc.
- I implemented parts of the TODO (email details)
- I switched from LABjs to yepnope.js, as LABjs is a discontinued project and made yepnope.js a submodule
- I cleaned the loader, so the workaround with the chrome URLs in the div elements is not needed any more
- I made jquery-bbq a submodule
- I switched to the jQuery Google CDN module, as it runs off HTTPS
- I cleaned the permissions in the manifest file
- I fixed the unread count and pulled in all fixes from other people's forks
- draft save/discard and starring/unstarring observers
- I cleaned the code a lot
- I switched it to use CoffeeScript to make it cleaner
- I defined constants for the observers
- I updated the documentation
not yet! been swamped lately.. I will try to take a look this weekend.
Changing the entire project to coffeescript is a big change, and I want to make sure I'll still be able to maintain it if we do that.
No worries! In my eyes th CoffeeScript change cleans it up a lot, but if it ever gets too much, you can always go back to JS by replacing the CoffeeScript with the JS compiled from it in future.
This is awesome :D I'm writing an extension based on Gmailr as well. I've been using CoffeScript to so this is perfect.
:) Let's hope James finds some time to merge the changes in then :-) Have you made additions to Gmailr as well?
@jamesyu did you find time yet to have a look at this changeset? Is there anything I can do to help with merging this in?
Sorry, still haven't found the time. After some more thought, I don't think I want to take this project into coffeescript, unless someone else wants to maintain it. I would be glad to take a look if this pull request made your changes, but in regular js.
Aw, that's too bad - anyone who knows JS should easily be able to understand the CoffeeScript. I really do not want to create a fork, but I think after a certain # of LOC it is just more easily maintainable in at least modularized form or something like CoffeeScript.
How about you make me Co-Maintainer of the project after pulling this? I'd be up for it and any problems that arise for you out of the project being CoffeeScript I am glad to have a Skype talk/Hangout/etc. - would that be an option?
This looks great @joscha! I might take this as an excuse to finally start using CoffeeScript :)
@michaelmior Please do :) It's only syntactical sugar anyway - nothing to be scared of! @jamesyu My Skype is joschafeth, shall we talk this week about it?
O by the way @michaelmior - you might want to check out: https://github.com/joscha/gmailui as well ;)
Thanks! I'll keep that in mind. Unfortunately I realized the project I was planning on isn't feasible (for non-technical reasons), but I'll definitely check it out if I think of something in the future!
hey Joscha -- sorry for dropping this thread.. I've been traveling and quite busy for the past month. I would be up for transitioning this project to a new maintainer, but I just don't even have the bandwidth right now to do the handoff.
If you were to instead make a smaller series of pull requests that makes your changes incrementally, it would be easier for me to incorporate them.
@jamesyu I guess it's kinda too late for that - logical changes are grouped as commits usually, but especially the transition to CoffeeScript is a bigger chunk - also I merged in all changes from other forks that fixed things over a timeframe of 5 months (ever since I opened the initial pull req). Handing off in github is as simple as adding me as a co-maintainer - the history gets preserved once we merge this pull in - so I guess you just have to decide whether this is an alternative or not.