cohorts icon indicating copy to clipboard operation
cohorts copied to clipboard

Updated the Google Analytics tracking for a non-interaction hit

Open kingo55 opened this issue 11 years ago • 4 comments

Hey James,

Excellent script you have here. I'm going to make a few changes, this is the first. The event tracking used to affect the bounce rate metric. Now it does not.

Have also started a blog post about this. I bet my readers will love this.

Rob

kingo55 avatar Mar 06 '13 04:03 kingo55

there are a bunch of issues with this pull request - specifically, i would like to keep the google analytics adapter as is.

jamesyu avatar Mar 10 '13 21:03 jamesyu

Thanks for the feedback, James.

I'll see about fixing those issues up. In retrospect removing the storage adapter wasn't the brightest move. I will, however need to define the custom variable slot number (cv_slot) when creating the test object.

As far as the way I'm which the experiment scope is defined (persisting over the duration of a visitor, session or page view), are you happy with that? I figure this kills two birds with one stone. We can set the cookie expiry and set the scope of the custom variable in one go. On 11/03/2013 8:11 AM, "James Yu" [email protected] wrote:

there are a bunch of issues with this pull request - specifically, i would like to keep the google analytics adapter as is.

— Reply to this email directly or view it on GitHubhttps://github.com/jamesyu/cohorts/pull/2#issuecomment-14689361 .

kingo55 avatar Mar 10 '13 21:03 kingo55

Yep, I like the scoping, that's very useful.

jamesyu avatar Mar 10 '13 22:03 jamesyu

Thanks again for the feedback, James. I've made some commits to address your suggestions and add a little more polish to my work. I'm really enjoying using the script and running experiments across a number of my sites.

Anyway, does the script look sufficient to you now?

Blog post about cohorts.js Also of interest, you may like to see the blog post I wrote about the project (of course, when the main project includes the updates, I'll switch the the link back):

http://www.optimisationbeacon.com/testing/using-cohorts-js-an-open-source-javascript-ab-mvt-library/

Of particular interest, I suggest a number of improvements which could add some additional value to the framework.

kingo55 avatar Mar 14 '13 06:03 kingo55