James Trew

Results 305 comments of James Trew

@Conni2461 I'm thinking some of this probably belongs in plenary.path. @davisthedev I'm also curious if using `:set shellslash` helps in any way in telescope.

Semi-related issue with plenary not gracefully handling windows paths set `shellslash` https://github.com/nvim-telescope/telescope.nvim/issues/2651

The `shellslash` stuff looks very hairy to fix. I don't think I have the capacity/patience to fix it especially with this being a cross-platform/windows issue and I don't easily have...

I did try out using `vim.fn.mode` in the minimal config example but it produces the same result. But I think your hunch is right that the `on_lines`, specifically the sending...

Maybe worth discussing is that with the currently implementation of the PR, for `grep_string` the rg submatch highlights aren't applied to de-conflict with `grep_string`'s sorter matches. ![image](https://github.com/nvim-telescope/telescope.nvim/assets/66286082/600546e8-8a0a-4028-b8e9-cd03ae23ecf3) ^ only the...

Yeah I'm not opposed to keeping `gen_from_vimgrep` and calling this new entry_maker something else for backwards compatibility reasons. > Another question i need to think about is if displayer is...

Sounds good. > " Telescope pickers will occur error: ![image](https://user-images.githubusercontent.com/13499986/254756434-d54566fa-f47b-4d77-89a5-917ad62a00de.png) I also gotta fix this eventually as well

Note to self: vim.base64?

@Marskey thanks I've incorporated your snippets. looks to be working well so far.

I also rebased everything. I switched out to using `vim.base64` over some copy/pasted code so this is now requires neovim 0.10. I think the intention was to make telescope 0.2.0...