cli-table2 icon indicating copy to clipboard operation
cli-table2 copied to clipboard
verified publisher icon jamestalmage

Fix for rowSpan on first two columns causes extra cells on the right

Open realityking opened this issue 8 years ago • 5 comments

Fixes #21

There might be a better way but this works 😄

realityking avatar Jul 07 '17 19:07 realityking

Coverage Status

Coverage increased (+0.001%) to 99.816% when pulling d797a38d63d18442e578a6a7e369ddb2a1bad670 on realityking:fix/issue-21 into 6b079445973a6c93d17d3ce23c28ab611baae89b on jamestalmage:master.

coveralls avatar Jul 07 '17 19:07 coveralls

@jamestalmage will this PR be merged? I face the same problem and hope this PR will solve it.

homerchen19 avatar Oct 30 '17 15:10 homerchen19

Sorry for being unresponsive on this. Any chance I can get you to write a regression test for this? (one that fails with the old code, and passes with the new).

jamestalmage avatar Dec 23 '17 02:12 jamestalmage

Thanks for getting back to this! I forgot all about how this works but I‘ll take a shot at it after Christmas.

realityking avatar Dec 23 '17 10:12 realityking

@realityking Thanks so much for the fix! I have the same bug in my project. @jamestalmage Can we have this merged? T-T

EmolLi avatar Nov 23 '18 19:11 EmolLi