James Shore

Results 26 comments of James Shore

Thanks! > the spike took so long and Angular did a fair amount of frustrating that I just fixed the tests and called it a day. That pretty much sums...

Looking at your code, it looks like you went with the 'change method' approach we used in the React review, rather than surrounding the immutable value objects with a mutable...

Thanks for the submission! I don't use TypeScript, so I can't validate this—and I'm uncomfortable merging code I can't check or maintain. But I'm happy to leave this pull request...

> I can submit to DefinitelyTyped, If it's not a problem for you. Sure, fine by me. I don't use TypeScript, so I can't verify the code you posted.

In prepping this for release, I discovered that it doesn't work on iOS. I didn't troubleshoot the problem, but I did notice that the CodeMirror site says that mobile browsers...

It looks like CodeMirror now supports iOS: https://github.com/codemirror/CodeMirror/issues/60 If anyone's interested in updating this patch to work with the latest version of CodeMirror, I'll take it.