react-composer icon indicating copy to clipboard operation
react-composer copied to clipboard

Perfomance: unnecessary rerendering

Open vanya2h opened this issue 6 years ago • 1 comments

Hi. First of all thanks for your work!

But here's i investigate some perfomance issues. I'm currently using why-did-you-render lib and have some interesting warnings:

2018-12-21 13 41 16

(another 3 warns is the same)

I believe react-composer changing component's children more than 1 time so it's produces some unnecessary rendering. Here I have 4 rerenders due to props.children !== prevProps.children

Thanks.

vanya2h avatar Dec 21 '18 10:12 vanya2h

Hi @kv9991 , I don't have a whole lot of experience with why-did-you-render, so I can't speak much to this. If you have ideas for perf improvements, feel free to suggest them!

jamesplease avatar Mar 28 '19 01:03 jamesplease