James Please

Results 313 comments of James Please

I spent more time thinking about this. Rather than using the request key stuff, I think that [`updateState`](https://github.com/tkh44/holen/blob/6f70f1bc1ebae96b6886184a52b6a502ed096de1/src/index.js#L46) should be called with a custom Error if a new request is...

#14 updated the _response_ body prop called [`type`](https://github.com/tkh44/holen/blob/13ddc77da4d9355ec129b37f121a70b8097dfc35/src/index.js#L138); this issue is referencing the _request_ body prop called [`body`](https://github.com/tkh44/holen/blob/13ddc77da4d9355ec129b37f121a70b8097dfc35/src/index.js#L115) 🙂 I like the prop name `body` since it comes directly from...

Ah, sorry – I should have been more specific. I'm alright with it working on string values, as I understand this library's goal to work with values of inputs. I'm...

> but I would still like to make it major bump. That makes sense to me. > So the best bet would probably be to change it to isInteger and...

> ... Thoughts? :+1: ! > so your couple PRs for this and #51 would be some nice additions to that release. I'll hop to it. Thanks @jfairbank !

Hi @ashishtilara ! Are you having a specific issue with any one part of Fortune? If you are, let us know and we can try to help out with the...

@daliwali let me know if you'd like help with any of this. I'm still learning my way around the code, but I'd be happy to learn and help out more...

@Stupidism it looks to me like both of the boilerplates are useful for "pure javascript" as well as "react component" libraries?

I think that’s a different problem. Maybe try some of the ideas over in https://github.com/electron-userland/electron-forge/issues/2412