backbone.intercept
backbone.intercept copied to clipboard
jamesplease
Add support for MacOS modifier key to bypass
I had to build this locally to test, as I couldn‘t get the test suite running properly, and daringly bumped the version number to reflect the patch.
This is getting a bit messy, but I guess all these commits can be squashed?
Yup, I wouldn't worry too about the commits. We can always use git rebase to clean em up before merge!
@Haraldson , if you wanted to go above and beyond here, you could look at other routing libraries to see how they manage this. For instance, the algorithm used by this code is largely taken from an older version of UI-Router.
If that doesn't sound interesting to you, then no worries. Go ahead and rebase it, and I'll give it one last review, then you can cut a release.
React Router doesn’t seem to care about the platform at all, but to me that seems sloppy. I’ll let this mature for a little while (I’ll be away traveling over Easter), and get back at it :)