backbone.intercept icon indicating copy to clipboard operation
backbone.intercept copied to clipboard

Published 20 hours ago • verified publisher icon jamesplease

in IE8 e.which is always 0 better to catch all mouse clicks then none

Open avipinto opened this issue 10 years ago • 2 comments

backbone.intercept didn't intercept any links on IE8 since jQuery sets e.which to 0 for left click on IE8 didn't create an issue for this but i can if you want me to

avipinto avatar Feb 25 '15 09:02 avipinto

Thanks for the PR, @avipinto!

When you get a chance, can you split this into 2 PRs? And don't worry about doing the build – I'll do that when it's time for a release.

jamesplease avatar Feb 25 '15 17:02 jamesplease

removed the version and squashed the commits for the queryString feature but i didn't find a way to split the PR. when i pushed to master on my fork, i didn't know it will update the PR.. will be happy to split the PR if you have a link to an explanation how to (the only way i can think of is removing this PR, moving each change to a separate branch and then doing a PR, this is how it is done?)

avipinto avatar Feb 26 '15 10:02 avipinto