jamesp-epcc

I am finally looking at this now. I plan to do the following: 1. Add a new class `PermissionResult` containing a boolean and a string for the message. The return...

I think it would be quite easy to allow policy packages that don't include the schema or the permissions module if they don't need it, and Rucio could fall back...

We could maybe solve this by adding logic to `validate_schema` so that instead of just fetching the named schema from the same module, it could check if the policy package...

I am not sure why this failed the end to end integration tests. All the checks passed on my repo and the failure is in the conveyor, which I haven't...

Hi, thanks for reviewing. I'm happy to make those changes. If no-one objects I will use a new attribute to determine whether the RSE is an object store or not...

Well spotted - I initially thought that GFAL (as opposed to HTTP) couldn't be called for objectstores, but in fact it can, so I've amended the code to catch the...

OK, this is breaking the tests because (I think) the mock response object doesn't have all the features of the real one. I will rethink how to solve this.

I've tried to make the download function work for every case without having to modify unrelated code such as the tests, but I'm open to suggestions for better ways to...

Thanks for the review and sorry it's taken me a while to get back to this. I'm happy to do it the way you suggest in your most recent comment...

The problem is that sometimes changes in the Rucio code break backwards compatibility with the policy packages (for example, changes to the signatures of permission functions), so a policy package...