James O'Gorman

Results 32 comments of James O'Gorman

Thanks for that confirmation. I've committed a change that removes the curl.

Hey @yabdali, thanks for that output, that's helpful. Do you still have this router in the broken state to be able to run some more commands? The first thing I...

You could try enabling logs in systemd (EdgeOS turns them off by default to not cause wear on the flash drive): ``` set system systemd journal storage volatile ``` That...

That screenshot shows your router does not have the correct time: note the SSL error saying "certificate is not yet valid".

Apologies for the delay in pushing updates. I got caught in the weeds a bit trying to understand some of the internals. I think I've addressed all of Alyssa's feedback,...

> Argh sorry I think the CI issue is real since some of this code goes in the mobile build which doesn't use exceptions. Can you take a look? Hopefully...

Digging through the codebase a bit, I think I could either: - `ENVOY_LOG(warn, "setting both xff_num_trusted_hops and xff_trusted_cidrs is not recommended")`; or - Revert some of d976354a8906b186d4b01f2ab995594b2cca5933 and: - Force...

Hey folks, any feedback to which approach I should take here? Thanks!

Not stale, waiting for feedback! But I'm also trying to find other examples in the codebase that do similar things, but there's a lot of code to examine...