James Butler

Results 274 comments of James Butler

I've rebased to update to the latest version of `pyupgrade` and re-run to be in compliance.

@jcfr I've included W1203 in the ignore of .flake8 configuration which I believe utilizes the pylint codes. https://pylint.pycqa.org/en/latest/user_guide/messages/warning/logging-fstring-interpolation.html

There was indeed some re-runs of pyupgrade as when you run it once and then immediately run it a second time, it will change more things the second time around....

Here' a screenshot from a private repo with an example of pyupgrade indicating changes: ![image](https://user-images.githubusercontent.com/15837524/196804743-6715962d-0b4a-47d4-9d68-44191e20e7f0.png)

@jcfr Do we have a build factory machine that supports this updated minimum now? re https://github.com/Slicer/Slicer/pull/6314#issuecomment-1177547745 ----------------------------------- In addition, macOS Catalina is now unsupported as well. In Slicer, do we...

As such, the factory-south-macos build has failed configuration for tonight’s build https://slicer.cdash.org/build/2824906/configure

Updating DCMTK from 3.6.6 to 3.6.7 will include this bug fix for Apple Silicon https://github.com/DCMTK/dcmtk/commit/5fba853b6f7c13b02bed28bd9f7d3f450e4c72bb https://github.com/Slicer/Slicer/blob/43b965ecbcf35293087b8c186f8fe75762094ba1/SuperBuild/External_DCMTK.cmake#L55

Closing now due to all of the merge conflicts. Starting over will be required.

Thanks for your work on this! I will try it out tomorrow. Maybe we can also revisit #5176 to improve the error log view as well to make it more...