James Munro

Results 9 comments of James Munro

Should this issue be included in this epic? - [ ] #1312

`get_num_rows` doesn't exist on Library, it's `lib._nvs.get_num_rows`. Can you check `lib.get_description`?

Rather than a special column name, `index`, perhaps a new arg, or an attribute on the returned object? ``` lib.read('symbol').index ```

This PR does change the stored and returned timezone data. We should likely hold off for a major version, just as with #1410 Is the original "Coordinated Universal Time" windows...

On `arcticdb==4.5.0` and probably before this produces an error, which is an improvement. ``` --------------------------------------------------------------------------- NormalizationException Traceback (most recent call last) [](https://localhost:8080/#) in () 5 lib = ac.get_library("arrays", create_if_missing=True) 6...

Link to the relevant comment: https://github.com/man-group/ArcticDB/pull/819#discussion_r1434311648

According to Python docs, the preferred way to interpret naive datetimes is as local time, and 'UTC' times should be passed with 'UTC' timezone. https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow

Thanks that does fix the case for when using `utcnow`. I think the other questions are still valid. 1. Why does it interpret a local/naïve datetime as UTC? 2. ~~Why...

> To be clear, are you suggesting that we should change the behaviour such that the read method, if a naive datetime is given, it is assumed to be in...