ReloadablePropertiesAnnotation icon indicating copy to clipboard operation
ReloadablePropertiesAnnotation copied to clipboard

Published 20 hours ago • verified publisher icon jamesmorgan

TypeConverter

Open davidlund opened this issue 10 years ago • 1 comments

Hi James,

Rather than implementing your own TypeConversion and hence adding dependencies onto Joda you should be able to hook into ConfigurableBeanFactory.getTypeConverter() (within your ReloadablePropertyPostProcessor - making it BeanFactoryAware) and use springs TypeConverter leaving it more extensible and you'd be able to chop a load of code! I've not tested this, but cant think why it wouldn't work.

Also suggest making your logback dependencies test scope for those log4j{2} users

davidlund avatar Oct 24 '14 20:10 davidlund

Alright dave, hope your well. Thanks for the tips, I've only just seen your comment. I however am unlikely to make many changes to this as I haven't used in a while. Feel free to open a PR if you like :)

jamesmorgan avatar Nov 18 '14 08:11 jamesmorgan