coravel icon indicating copy to clipboard operation
coravel copied to clipboard

[Docs] RunOnceAtStart docs seem to be incorrect

Open Eric-Bonneau opened this issue 2 years ago • 2 comments

Hi,

I'm not sure what issue type to open for this, but I may have found an issue with the documentation found here.

Describe the bug The example shows:

scheduler.Schedule<CacheSomeStuff>()
    .RunOnceAtStart()
    .Hourly()
    .Weekday();

When I try to do the same, it doesn't seem like the method is available on IScheduleInterval:

image

Affected Coravel Feature Scheduling, specifically the run once at start functionality.

Expected behaviour It seems like RunOnceAtStart is only available as a method on IScheduledEventConfiguration and the example should therefore be:

scheduler.Schedule<CacheSomeStuff>()
    .Hourly()
    .Weekday()
    .RunOnceAtStart();

Side note

Thanks a lot for all your hard work. This package has made running scheduled jobs a breeze!

Eric-Bonneau avatar Jan 07 '22 16:01 Eric-Bonneau

Thanks Eric! Good find 😉

jamesmh avatar Jan 07 '22 16:01 jamesmh

I can confirm that the docs are still wrong.

But yeah, nice job on a great library! Thanks for creating this!

Xenovore avatar Jul 19 '22 22:07 Xenovore

This should be fixed now (or whenever the docs build ina few min lol)

jamesmh avatar Aug 19 '22 03:08 jamesmh

hi, the RunOnceAtStart() method is present. but no start Job-4.0.5 version.Need to upgrade to 4.1.0 version?

545867454 avatar Dec 29 '22 08:12 545867454

Don't remember... I think there was an issue in a past version. Try 4.1.0 and see if it fixes it 😃

jamesmh avatar Dec 29 '22 21:12 jamesmh