coravel icon indicating copy to clipboard operation
coravel copied to clipboard

Published 20 hours ago • verified publisher icon jamesmh

#233 - The existing IScheduler interface has ScheduleWithParams<T> me…

Open karthikveeraj opened this issue 3 years ago • 3 comments

This is the fix for ticket #233

The existing IScheduler interface has ScheduleWithParams<T> method which supports only generic type as a parameter. If the types are getting loaded dynamically, it is not possible to use the method ScheduleWithParams with the type. Hence, I'm adding an additional overloaded method that takes invocableType as a parameter instead of a generic type. This helps me to dynamically load the jobs with parameters.

I have ensured all tests are passing with code coverage of 100% for this new method. Kindly review as soon as you can as I'm waiting for the new NuGet package for this.

Test results and code coverage : image

image

@jamesmh - Please look into this.

karthikveeraj avatar Jun 07 '21 04:06 karthikveeraj

@jamesmh - Can you review this PR?

karthikveeraj avatar Jun 08 '21 16:06 karthikveeraj

@jamesmh - Can you please complete the review ? this is PR is in pending for a long time.

karthikveeraj avatar Jul 05 '21 18:07 karthikveeraj

Hey @karthikveeraj, just checking if you're still interested in completing this?

Thanks again for your effort and time 👍

jamesmh avatar Sep 08 '21 02:09 jamesmh

Any progress with this PR?

IonRobu avatar Nov 08 '22 15:11 IonRobu

Any news?

billhong-just avatar Mar 06 '23 09:03 billhong-just

This is part of 4.2.1. Let me know if there are any issues - thanks for your patience!

jamesmh avatar Mar 08 '23 02:03 jamesmh