James McNamara
James McNamara
@fkling When I go to S2 or dotcom I see that it hits an error on `loadForeignModule` which is presumably the call from monaco to async-load the workers which don't...
Good news is that it wasn't a weird S2 issue! Somehow along the way I managed to merge your changes into my local main so when I was building it...
@bahrmichael What we've done in the past for this is just stub out any calls from the test driver to just return static files. So for example we'd [intercept all...
@bahrmichael I added a commit that makes all the tests green :) I removed Polly and just used playwright's native [network mocking](https://playwright.dev/docs/network). As far as the manifest, we're in luck...
@bahrmichael Alright I made some progress on this [here](https://github.com/sourcegraph/sourcegraph/pull/60897/commits/2bb9399367da9617e2a061161a95d2fad339574d). After a lot of digging it seems the problem comes from there actually being two copies of playwright somehow in the...
Little update: I've zeroed in on the exact line that is causing the issue (in brief if the test suites are loaded as ESM it's reinitializing playwright in a new...
@vovakulikov Yes I did get that same error. Let me see if I can find a quick fix.
Still looking into this, but adding `frontend` to the command set for web-standalone and changing `web-standalone-http` to web works. But I assume the goal of web-standalone-http is to not have...
@vovakulikov Alright I made a few changes that seem to have helped me locally. 1. I [added this command](https://github.com/sourcegraph/sourcegraph/pull/59219/files#diff-bb8e3383b3d6ce6cc850d8aea2c04d5c800914ad30da787ccca0bdab8e0fc3b4R404-R410) to start the vite dev server in the `web-standalone` command. 2....
@vovakulikov [this](https://github.com/sourcegraph/sourcegraph/pull/58228#discussion_r1427896712) was the original thread on web-standalone-prod. It seems like we could retain it if it is actually needed?