inline_svg
inline_svg copied to clipboard
Run GitHub Actions on PRs
Hi, I've noticed that PRs do not run actions, so they can introduce issues that will only discovered when merged to master
--
Also:
- Set explicit permissions to read for better security
- Update actions
Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions
Blocked by
- [x] jamesmartin/inline_svg_test_app#23
- [ ] #156
I'm facing some issues related to the usage of an old version of webpacker which still uses node-sass, and Python 2.7 is not available anymore. I guess that https://github.com/jamesmartin/inline_svg_test_app/tree/rails6-webpacker needs an updated, but then we should use webpacker 5.x
Thanks for opening this PR. New branch created in the inline_svg_test_app repo for rails7-shakapacker so you can get the integration tests running.
@jamesmartin thanks, really appreciate. I'll move forward with this, then we can drop
@jamesmartin all green here, no changes to production code, should be safe to merge and will fix the failing badge
Thanks again, @tagliala! ✨