inline_svg icon indicating copy to clipboard operation
inline_svg copied to clipboard

Support Shakapacker 8

Open tagliala opened this issue 1 year ago • 2 comments

Shakapacker 8 removed Webpacker spelling ref: shakacode/shakapacker#429

This is preventing CI to pass: https://github.com/diowa/icare/pull/1725

I'm working on a PR

tagliala avatar May 18 '24 22:05 tagliala

We faced the same issue, ended up adding a monkey patch via an initliazer

module InlineSvg
  class WebpackAssetFinder
    Webpacker = Shakapacker

    if Rails.env.development?
      class Shakapacker::DevServer
        def https? = false
      end
    end
  end
end

leondmello avatar May 29 '24 15:05 leondmello

@leondmello can you test this branch? https://github.com/tagliala/inline_svg/tree/feat/support-shakapacker

tagliala avatar May 29 '24 16:05 tagliala

Apologies for the lack of updates recently. I'll be moving forward with support for Shakapacker 8, roughly following the strategy outlined by @tagliala.

In addition, I'll be bumping this gem to 2.0, at which point it will drop official support for the older versions of Rails and will move to align with the official Rails maintenance policy, which means versions of Rails that have reached end-of-life will not be supported.

jamesmartin avatar Sep 03 '24 02:09 jamesmartin

@leondmello can you test this branch? https://github.com/tagliala/inline_svg/tree/feat/support-shakapacker

Thanks for the fix! Sorry, couldn't check this earlier.

leondmello avatar Nov 27 '24 16:11 leondmello