Missing dependencies

[ryansukale]

Hey, thanks for this nice library.

It seems like when I tried to mock the post request and then make the request with a body, i got the following errors one after the other in MockXMLHttpRequest.js file.

Document is undefined Blob is undefined FormData is undefined

In order to make my post request work I had to do the following in my test file at the top.

import {JSDOM} from 'jsdom';
import {Blob} from 'blob-polyfill';
import FormData from 'form-data';

global.window = (new JSDOM()).window;
global.Document = window.Document;
global.Blob = Blob;
global.FormData = FormData;

My test environment is nodejs v8.9.1

Are you are missing these dependencies?

[jameslnewell]

Hi @ryansukale. Thanks for reporting the issue! Are you posting Blob and FormData or do you still get the errors with an ordinary post? Ordinary posts should work fine, but using FormData or one of the objects not native to nodejs will definitely cause errors. Polyfilling them is a great idea and I'd be happy to move that into the library.

Could you please provide a minimal test case to reproduce the errors. Thanks!

[ryansukale]

@jameslnewell

I am getting it with a regular post with a JSON body

const responseBody = {hello: 'world'};
    const request = {body: 'message'};
    mock.post(path, {
      status: 201,
      body: JSON.stringify(responseBody)
    });

    ajaxObservable
      .postJSON(path, request)
      .subscribe(data => {
        expect(data).to.deep.equal(responseBody);
        done();
      });
// And my postJSON is a wrapper around Rx.ajax method to post stuff, which does something like this.

return Rx.DOM.ajax({
    url,
    method: 'POST',
    responseType: 'json',
    body
  }).map(({response}) => response);

I went through the code in the MockXMLHttpRequest file. If you see the lines - Here and the other conditions that follow, it seems to expect the Document and Blob and FormData to be present globally as long as body is present in the payload.

I am testing using mocha and sinon. Thats some more additional context if it helps.

[jameslnewell]

I was wondering why the tests aren't failing on nodejs... because jest sets up jsdom 🤦‍♂️

I'll work on a fix. I'm thinking I'll add additional checks for Document, Blob and FormData so that standard string bodies work, but the user is required to provide polyfills for those objects if they're not using jest AND if they have requests that rely on one/any of those objects.

What do you think?

[jameslnewell]

@ryansukale please try [email protected]

[ryansukale]

Since its a testing framework, why not use those dependencies? Otherwise, can you mention in the documentation that the library expects certain objects to be present. And if testing outside of jest environment, perhaps you can recommend the libraries I used? Hunting for libraries is a pain, and would hinder adoption of this library. It would be nice to point people in some direction.

I will try with the version you specified and report back.

[ryansukale]

I just tested the "xhr-mock": "2.4.1-preview.1" release and it works for my use case. However, do consider adding the recommended libraries as part of the docs.

Thanks!

[deini]

Had the same issue and 2.4.1-preview.1 fixes it. 💯

[jameslnewell]

Thanks for the reminder :) I just released 2.4.1 but I won't close this issue yet as I want to document the usage with non-jsdom environments.