James Lamb

Results 1162 comments of James Lamb

If you're changing things in the Travis console and then clicking "rebuild", it's possible that that won't work because stuff is cached. I've noticed behavior like that with other CI...

Thanks for using `{uptasticsearch}`! > doesn't let me run a query for reasons I don't understand Can you provide any logs or error messages that could help us to understand...

For contributors...see the links in that `pkgnet` comment above for documentation on how to do this

To close this issue, I actually think it would be ok to just install the package, set whatever environment variable tells testthat that it's on CRAN, and then runs the...

@skirmer I came across this issue again tonight while re-organizing our backlog. Not sure how soon @austin3dickey @ngparas or I will be able to spend time on `uptasticsearch`. Any interest...

happy to report we have near-100% coverage now as of #66! Still leaving this open...we would love help covering the last few tough-to-hit cases

coverage as of #72 ![image](https://user-images.githubusercontent.com/7608904/41582182-80f5ca6e-7366-11e8-90c7-9cc736671e8b.png) ^ note that those `get_fields` lines are actually covered...there are two scrolling strategies (one for new, one for legacy), and only one of the two...

so our coverage is above 97%! Those last few lines would be real real hard to cover, but someone is welcome to take this up if they really want

If you want to contribute on this, here's how you can check the test coverage: 1. Spin up Elasticsearch locally and seed it with data. This requires that you have...

@austin3dickey @ngparas I actually tried this today, but [AFAICT you can't use x-pack security in the free images](https://discuss.elastic.co/t/security-exception-current-license-is-non-compliant-for-security-with-license-expired-feature-security/97351). Other links I found in case someone figures out how to do...