create-react-blog icon indicating copy to clipboard operation
create-react-blog copied to clipboard

Published 20 hours ago • verified publisher icon jamesknelson

Linter warnings alt required for <Img tags

Open NickFoden opened this issue 5 years ago • 3 comments

Maybe this is a within markdown issue so a non issue?

But I believe the default create react app linting that warns <img tags require an alt attribute is turned off and I suggest this project turns that warning back on.

NickFoden avatar Mar 03 '19 22:03 NickFoden

AFAIK the linter can't lint markdown files, so this would be pretty hard to fix

I'll close this for now, but feel free to re-open if you want to try submitting a PR with a fix to react-scripts-mdx.

jamesknelson avatar Mar 04 '19 01:03 jamesknelson

Realized this is also issue in regular .js components. Is this easy linting rule to put back? I think where possible good to remind users to include this alt tag for <img in their .js components.

I will look for linting markdown, but I think you are right may be hard/impossible to do.

NickFoden avatar Mar 04 '19 06:03 NickFoden

This should definitely work for .js files. Not sure what's gone wrong.

jamesknelson avatar Mar 04 '19 06:03 jamesknelson