f90wrap icon indicating copy to clipboard operation
f90wrap copied to clipboard

Improve handling of continuation lines

Open jameskermode opened this issue 8 years ago • 5 comments

For example, the following doesn't work:

recursive &
subroutine sub(...)

Probably removing all "&" symbols all and joining into long lines before doing any parsing would be safer.

jameskermode avatar Dec 02 '15 15:12 jameskermode

It is my opnion that f90wrap would be best served over the long run by switching to an existing Fortran parser (probably based on a published Fortran grammar). This would probably require a lot of rewriting, but I think it would be the easiest / most reliable way to move f90wrap to the next level of completeness with the Fortran spec.

On Wed, Dec 2, 2015 at 10:56 AM, James Kermode [email protected] wrote:

For example, the following doesn't work:

recursive &subroutine sub(...)

Probably removing all "&" symbols all and joining into long lines before doing any parsing would be safer.

— Reply to this email directly or view it on GitHub https://github.com/jameskermode/f90wrap/issues/35.

citibeth avatar Dec 03 '15 01:12 citibeth

I'm sure you're right Bob, but as you say this is a lot of work. When I started f90wrap I could not find any Python implementations of Fortran parsers that were sufficiently complete. The one developed as part of the 3rd generation f2py is promising but does not appear to be under active development.

jameskermode avatar Dec 03 '15 10:12 jameskermode

@jameskermode i've yet to find a continuation line that did parse. For me, ssues with argument lists to subroutines spanning multiple lines.

This is an exciting and useful project that I hope continues! Thanks for your efforts!

jlkittle avatar Mar 17 '16 14:03 jlkittle

@jlkittle Thanks for the feedback. If you post some examples of subroutines that don't parse I'll take a look. Pull requests also very welcome :-)

jameskermode avatar Mar 18 '16 16:03 jameskermode

I am traveling until about March 30.  Will be back in touch then.

Sent from Samsung tablet

-------- Original message -------- From James Kermode [email protected] Date: 03/18/2016 12:06 (GMT-05:00) To jameskermode/f90wrap [email protected] Cc Jack Kittle [email protected] Subject Re: [f90wrap] Improve handling of continuation lines (#35)

@jlkittle Thanks for the feedback. If you post some examples of subroutines that don't parse I'll take a look. Pull requests also very welcome :-)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

jlkittle avatar Mar 19 '16 14:03 jlkittle