github-activity-readme
github-activity-readme copied to clipboard
jamesgeorge007
Feat: Adds option to specify the target file
Hi @jamesgeorge007 👋 Love your action, it's been very useful :)
Re issue: #68, #48, #56
This PR implements the option to use a file other than the readme, by specifying a TARGET_FILE.
If it isn't specified, it will continue to use README.md, so is fully backwards compatible.
Let me know if there's anything you'd like me to change, Have a great day!
It seems to be only detecting changes in the README.md file. Have you tested it?
In my case, I have a loop to target different README.md files as a TARGET_FILE (which is targeting the correct TARGET_FILE) but I've also tried it using an isolated action (see https://github.com/fbuireu/fbuireu/runs/6252387075?check_suite_focus=true) or the following screenshot:
In this case, README.es.md is far way not updated and different from the README.md but it's outputting "no changes detected".
Have you tested it?
Yeah, I'm running it in this workflow run.
Which is defined in workflows/recent-activity.yml and is updating Lissy93/RECENT-ACTIVITY.md.
It seems to be working just fine, but I'm pretty new to GitHub actions, so I could be missing something?
I think you are missing the changes in the distribution file (https://github.com/Lissy93/github-activity-readme/blob/master/dist/index.js).
I've forked your repo to apply the required changes (based on this PR) but I'm not able to make you a PR because the upstream is gone and I don't want to create another PR either because you earnt the credit.
It seems to work on my custom GitHub action right now. If you want to update the distribution index.js based on mine here it is: https://github.com/fbuireu/github-activity-readme
By the way, thanks for the PR and the effort :)
@fbuireu, you're totally right, thanks for explaining :) Dumb mistake on my part, I've updated it now, tested and seems to be working
@jamesgeorge007 - Project still alive? It's nice work on your part, and your GH action seems to have been very popular with the community. So it would be good to get some updates pushed out, PRs reviewed / coded, or a note about weather it's still maintained.
@Lissy93, thank you so much for the kind words, and my apologies for the delayed response. I'd love to see this project going ahead. Unfortunately, I'm short on bandwidth currently. May I know if you are interested in being a collaborator?
