github-activity-readme icon indicating copy to clipboard operation
github-activity-readme copied to clipboard

TypeScript rewrite, new options, improved workflows & whatnot

Open EndBug opened this issue 5 years ago • 6 comments

Disclaimer: I know this is a huge PR and it's not ideal to have so many changes in a single one. The only reason it's this way it's because I needed to develop it for my README and I couldn't wait for all the changes to be gradually merged in this repo.

Changelog:

  • The action is now written in TypeScript, providing static type checking.
  • There are now 3 new options:
    • LINES: you can use different numbers of lines.
    • NO_COMMIT: the action won't commit the resulting file.
    • NO_DEPENDABOT: the action will filter out events triggered by merging or closing a PR by Dependabot. The reason for this is that I found my actions to be mainly populated by this kind of events since I merge a lot of these PRs.
  • The action can now fetch more events, if after the first 100 don't contain enough eligible ones: it will keep requesting events until they end.
  • The dist folder is updated automatically by a workflow (update.yml), which also runs prettier.
  • The test workflow has been removed, since the update workflow is already handling the testing (it doesn't run on a matrix, but I think that's fine: almost nobody will need to run this action on macOS, and the action doesn't have platform-specific code)

EndBug avatar Sep 14 '20 20:09 EndBug

Also, I was thinking of changing the emoji for issue comments to 💬 because it looks better (at least on Windows). Is that ok?

EndBug avatar Sep 23 '20 16:09 EndBug

Also, I was thinking of changing the emoji for issue comments 💬 because it looks better (at least on Windows). Is that ok?

Looks better on windows? I didn't get your point.

jamesgeorge007 avatar Sep 26 '20 06:09 jamesgeorge007

Also, I was thinking of changing the emoji for issue comments 💬 because it looks better (at least on Windows). Is that ok?

Looks better on windows? I didn't get your point.

In my opinion, that emoji looks better if compared to the current one (🗣) which, at least on my machine (that runs Windows), looks like this: image

I just think the other emoji is clearer and fits better with the other ones. That's just my personal opinion: what do you think about it?

EndBug avatar Sep 26 '20 07:09 EndBug

Ok, now there should be no more conflicts

EndBug avatar Nov 21 '20 22:11 EndBug

Just as a sidenote: I understand that this is a huge PR and everything, but I'd like you to make a decision on whether to merge this or not. It's already the second time I resolve conflicts because you keep updating the master branch without merging the PR. I'm fine with you not merging the PR, but I'd like to know whether you're eventually going to do it or not. If you want to keep waiting, just be aware that you'll have to resolve the merge conflicts yourself (you already have push access to this PR's branch)

EndBug avatar Nov 28 '20 14:11 EndBug

I'm sorry for making you wait; it's just that there is plenty on my plate. I had to land a couple of PR's as the need came in, and yeah, they were small. Thank you so much for putting in the efforts here; I'll take a look as time permits.

jamesgeorge007 avatar Nov 28 '20 17:11 jamesgeorge007