graphql-authentication icon indicating copy to clipboard operation
graphql-authentication copied to clipboard

Craft CMS 5 compatibility

Open mgambella opened this issue 1 year ago β€’ 7 comments

With Craft CMS 5 released, I wanted to check if this is going to be updated for the new version.

mgambella avatar Apr 19 '24 20:04 mgambella

How’s it going with Craft 5? We’re pretty dependent on this plugin and looking forward to craft 5 edition. Any sense of timescale? Thanks

robinbeatty avatar May 01 '24 23:05 robinbeatty

Was also wondering. I really need this plugin for Craft 5

DTesch-Level-R avatar May 03 '24 13:05 DTesch-Level-R

Will try to get something out this weekend – @brandonkelly has sorted most of it in https://github.com/jamesedmonston/graphql-authentication/pull/151 πŸŽ‰

jamesedmonston avatar May 16 '24 09:05 jamesedmonston

Any timeline updates on this topic? I'd really like to start a project soon but my choice between craft4/craft5 or another CMS altogether depends on the availability of this plugin.

sir-savien avatar May 29 '24 10:05 sir-savien

Working through this now everyone. Big thanks to @brandonkelly for sorting the initial PRs

jamesedmonston avatar Jun 02 '24 16:06 jamesedmonston

You can now test it by installing the develop branch through Composer.

Currently, 2FA support is disabled, and named section queries aren't restricting to the authed user – i.e. if you have a channel called Page, the pageEntries query won't be restricted. You can use the following query in the interim:

query Entries {
  entries(section: "page") {
    ...
  }
}

I will work on updating the 2FA implementation to use Craft's built-in stuff, and work out a way to restrict the named queries.

jamesedmonston avatar Jun 02 '24 21:06 jamesedmonston

Any updates on a stable version?

sir-savien avatar Jun 27 '24 12:06 sir-savien

Any updates on a stable version?

I would also like to know. We've got a few clients seeking to upgrade to Craft5. Thanks in advance.

mrbenito avatar Jul 29 '24 17:07 mrbenito

Thanks for your work on this, I'm waiting on the C5 version also but having difficulty even installing with dev-develop (and --with-all-dependencies) on a relatively vanilla Craft installation.

  Problem 1
    - jamesedmonston/graphql-authentication[dev-craft3, 1.0.0, ..., 1.12.3] require craftcms/cms ^3.5.0 -> found craftcms/cms[3.5.0-beta.1, ..., 3.x-dev] but it conflicts with your root composer.json require (5.2.3).
    - jamesedmonston/graphql-authentication dev-develop requires lcobucci/jwt ^5.3.0 -> found lcobucci/jwt[5.3.0, 5.3.x-dev, 5.4.x-dev] but these were not loaded, likely because it conflicts with another require.
    - jamesedmonston/graphql-authentication[dev-master, 2.0.0, ..., 2.5.0] require craftcms/cms ^4.0.0-alpha.1 -> found craftcms/cms[4.0.0-alpha.1, ..., 4.x-dev] but it conflicts with your root composer.json require (5.2.3).
    - Root composer.json requires jamesedmonston/graphql-authentication * -> satisfiable by jamesedmonston/graphql-authentication[dev-master, dev-craft3, dev-develop, 1.0.0, ..., 1.12.3, 2.0.0, ..., 2.5.0].

chrisrowe avatar Aug 05 '24 20:08 chrisrowe

Eagerly awaiting this plugin for Craft 5. Any word on the latest?

jpcarpenter avatar Aug 12 '24 20:08 jpcarpenter

Honestly it's outrageous this feature isn't handled directly by @pixelandtonic Pixel and Tonic. James is doing god's work, but cmon, our entire headless authentication solution shouldn't rest on one man. Our firm has made the decision to just NOT move to the next version of craft for 12 months so guys like James has plenty of time to get around to updating this kind of thing.

mrbenito avatar Aug 13 '24 01:08 mrbenito

Honestly it's outrageous this feature isn't handled directly by @pixelandtonic Pixel and Tonic. James is doing god's work, but cmon, our entire headless authentication solution shouldn't rest on one man. Our firm has made the decision to just NOT move to the next version of craft for 12 months so guys like James has plenty of time to get around to updating this kind of thing.

I fully agree on the first part of your comment, and i'd fully agree on the second part too, if this was a free product. Since it's not, i'd at least like some form of update/communication regarding a schedule. Even a "i won't update this for craft 5" would be better than very sparse comments with long silences inbetween.

sir-savien avatar Aug 19 '24 10:08 sir-savien

Sorry for the delay everyone.

I've finalised the remaining pieces (2FA and named section query restrictions) and fixed a couple of issues.

Sorting out a 3.0.0-RC1 release now.

jamesedmonston avatar Aug 26 '24 15:08 jamesedmonston

@jamesedmonston Thanks for all your hard work on this!

chrisrowe avatar Aug 26 '24 20:08 chrisrowe

πŸ‘πŸ‘πŸ‘πŸ‘

On Mon, Aug 26, 2024, 4:43β€―PM Chris Rowe @.***> wrote:

@jamesedmonston https://github.com/jamesedmonston Thanks for all your hard work on this!

β€” Reply to this email directly, view it on GitHub https://github.com/jamesedmonston/graphql-authentication/issues/149#issuecomment-2311056008, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLYWM2MNOKMMLHCVQ5KKFTZTOHQPAVCNFSM6AAAAABGPZW7USVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJRGA2TMMBQHA . You are receiving this because you commented.Message ID: @.***>

mrbenito avatar Aug 27 '24 12:08 mrbenito