James C. Davis

Results 28 comments of James C. Davis

@chancancode there are some basic runtime tests, but they are very incomplete. I'm not sure why CI is failing. Tests are passing locally.

Needs rebased to resolve conflicts. @aaxelb?

You are using the helpers correctly and this is a valid issue. Glint is actually doing the "right thing" here types-wise, but it's inconvenient. Indeed, the `if` is narrowing `this.showModal`...

Yeah, I don't love the inconsistency that would be introduced by special-casing of booleans (even though I proposed it 😆). And my first instinct was also, "don't use `mut`" 🙂.

But also, I'm having trouble reproing this. In a test app, I set all my versions the same as listed here and Glint is not complaining about `{{fn (mut this.foo)...

Thanks for the repro! It's erroring as expected for me. Not sure what I messed up in my test app. It was previously on an older version of Glint and...

@mastastealth are you seeing this in an engine? I am experiencing the same error in a engine ([here's a repro](https://github.com/jamescdavis/modifier-destroy-engines-test)), but have not been able to repro in an app...