James Robb

Results 11 comments of James Robb

@alexismartin i've noticed that there's also a (mildly annoying but not fatal) issue when deleting the expiry date in firefox. The backslash is deleted on key down, but then re-added...

This relates to the issue i explained on Friday (#135) about completely removing the 'rejected' error/errors in the `validate-multiple-fields` directive when validating a required `RadioSelect` or `CheckboxSelectMultiple`. This demonstrates that...

**Problem** Using a `$viewChangeListener` to remove the 'rejected' error means that the error will only be removed if the input is interacted with. But not if the model data is...

We can go one step further by moving the specific logic to add/remove 'rejected' errors into (namespaced) methods on each `ngModel`. ``` djng_forms_module.directive('djngRejected', function() { return { restrict: 'A', require:...

Finally, i've refactored the `validate-multiple-fields` directive to work with these other updates. Also (going back to my earlier comment about calling `$setValidity()`directly on a form) instead of setting `$setValidity('required', false)`...

**That's everything**. Sorry for the _sligthly_ verbose explanation, i just wanted to be clear on why i've made the decisions i have when refactoring this logic.

@niamleeson `$ngRedux` middleware can be strings: https://github.com/angular-redux/ng-redux#createstorewithreducer-middlewares-storeenhancers-initialstate So you can create an angular factory, into which you can inject your epics (or service that creates you epics) and then `return...

Have you tried setting the second argument of `addImage` to the correct image type? Does that help?

A couple of solutions. The first creates a Tuple the length of the low number and a Tuple the length of the high number (both populated with numbers), converts them...