modal_bottom_sheet icon indicating copy to clipboard operation
modal_bottom_sheet copied to clipboard
verified publisher icon jamesblasco

fix: keep state in memory in ModalBottomSheetRoute

Open LeGoffMael opened this issue 3 years ago • 3 comments

Fix #252, #255. Was caused by d350f4b66fcb11c3178fc69f09005de16f9ef7d7.

ModalBottomSheetRoute was previously using PopupRoute, where maintainState was default to true. This fix simply reproduce this behavior.

LeGoffMael avatar Jul 05 '22 05:07 LeGoffMael

@jamesblasco Could you please look at this PR and merge it?

filipljusic avatar Jul 15 '22 14:07 filipljusic

Hello, same problem. Merge it plz

DrNorton avatar Aug 02 '22 09:08 DrNorton

Hello, Merge it pls

MrNB0dy avatar Aug 10 '22 15:08 MrNB0dy

@LeGoffMael Can you grant me access to the PR branch? I can add a test to avoid future breaking.

AlexV525 avatar Aug 28 '22 08:08 AlexV525

Just sent you an invitation as collaborator @AlexV525 ! Thanks for the helps~

LeGoffMael avatar Aug 28 '22 09:08 LeGoffMael

I think the mainState can be exposed for controllable and defaults to true. WDYT? @LeGoffMael

AlexV525 avatar Aug 28 '22 09:08 AlexV525