modal_bottom_sheet icon indicating copy to clipboard operation
modal_bottom_sheet copied to clipboard

Dragging back up is abrupt

Open wandbrandon opened this issue 4 years ago • 6 comments

When having a list view within a modal, dragging back up causes an abrupt change to it's normal state. ezgif-4-9a35d97cee5c

wandbrandon avatar Dec 05 '20 20:12 wandbrandon

Hey @jamesblasco any news/thoughts on this one ? :) I tried to apply your custom BottomModalScrollPhysics from PR #77 , but did not fix the issue. Your package is great, but this is the only annoying thing holding me from using it in a real app 😔 I could give a try to fix it when I'll have time

BazinC avatar Jan 14 '21 10:01 BazinC

I figure out the problem of this. I am working on it.

Right now the duration of the animation is proportional to the distance the modal has to travel. Short distances will mean faster animations. I will change that in the upcoming version

jamesblasco avatar Feb 19 '21 15:02 jamesblasco

Hi, I just wanted to add that I noticed that it could even cause the bottom sheet to close if we drag it too low and come back up. I hope this will be fixed soon because apart from that I love this package!

Here is the issue in video (I am always dragging, never releasing):

bug_dragging_too_low

lulupointu avatar Apr 12 '21 11:04 lulupointu

I'm also curious if there's any ideas of this, it's a blocker for me as well with smooth scroll down but abrupt jump all the way up when scrolling upwards.

It's very apparent on the demo for Avatar Modal here: https://jamesblasco.github.io/modal_bottom_sheet/#/

proformance avatar May 08 '21 08:05 proformance

Hi, I just wanted to add that I noticed that it could even cause the bottom sheet to close if we drag it too low and come back up. I hope this will be fixed soon because apart from that I love this package!

Here is the issue in video (I am always dragging, never releasing):

bug_dragging_too_low

This indeed is a small bug an otherwise great package!

woutervanwijk avatar May 18 '21 10:05 woutervanwijk

@jamesblasco Hi!

Tell me, please, do you plan to fix this bug?

Maybe you can tell me where to fix it and I'll do the PR if you don't have time?

otopba avatar Feb 11 '22 10:02 otopba